linux-kernel - Re: [PATCH v6 03/18] clk: qcom: gcc-ipq806x: add PXO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62570197.1c69fb81.c3de2.7b70@mx.google.com>
Date:   Wed, 13 Apr 2022 19:00:06 +0200
From:   Ansuel Smith <ansuelsmth@...il.com>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 03/18] clk: qcom: gcc-ipq806x: add PXO_SRC in clk table

On Thu, Mar 24, 2022 at 06:22:29PM -0700, Stephen Boyd wrote:
> Quoting Ansuel Smith (2022-03-24 18:13:49)
> > On Thu, Mar 24, 2022 at 06:10:35PM -0700, Stephen Boyd wrote:
> > > Quoting Ansuel Smith (2022-03-21 16:15:33)
> > > > PXO_SRC is currently defined in the gcc include and referenced in the
> > > > ipq8064 DTSI. Correctly provide a clk after gcc probe to fix kernel
> > > > panic if a driver starts to actually use it.
> > > > 
> > > > Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> > > > ---
> > > 
> > > What is this patch about? clk providers shouldn't be calling clk_get().
> > >
> > 
> > If pxo is passed as a clock in dts and defined as a fixed clock, what
> > should be used? 
> 
> clk_parent_data

Sorry but I'm not following you. No idea if you missed the cover letter
where i describe the problem with PXO_SRC.

The problem here is that
- In DTS we have node that reference <&gcc PXO_SRC>
But
- gcc driver NEVER defined PXO_SRC
As
- PXO_SRC is actually pxo_board that should be defined as a fixed-clock
  in dts or is defined using qcom_cc_register_board_clk.

So in theory we should just put in PXO_SRC the clk hw of the
fixed-clock. That is why I'm using clk_get(). I can use __clk_lookup()
as an alternative but I really can't find a way to get the clock defined
from DTS or qcom_cc_register_board_clk.

(I have the same exact problem with the cpu qsb clock where is defined
using fixed-clock API but can also defined directly in DTS and I have to
use clk_get())

I'm totally missing something so I would love some hint on how to solve
this.

-- 
	Ansuel