linux-kernel - Re: [PATCH v4 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YlcCEP8ADyJNxd/Z@smile.fi.intel.com>
Date:   Wed, 13 Apr 2022 20:02:08 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Chen-Yu Tsai <wens@...nel.org>, Rob Herring <robh@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        dri-devel@...ts.freedesktop.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH v4 4/5] drm/solomon: Move device info from ssd130x-i2c to
 the core driver

On Wed, Apr 13, 2022 at 06:23:57PM +0200, Javier Martinez Canillas wrote:
> These are declared in the ssd130x-i2c transport driver but the information
> is not I2C specific, and could be used by other SSD130x transport drivers.
> 
> Move them to the ssd130x core driver and just set the OF device entries to
> an ID that could be used to lookup the correct device info from an array.
> 
> While being there, also move the SSD130X_DATA and SSD130X_COMMAND control
> bytes. Since even though they are used by the I2C interface, they could
> also be useful for other transport protocols such as SPI.

Thanks!

...

> @@ -139,6 +106,8 @@ static struct i2c_driver ssd130x_i2c_driver = {
>  };
>  module_i2c_driver(ssd130x_i2c_driver);
>  
> +

Seems stray change. Dunno if maintainers can fix this when applying.

>  MODULE_DESCRIPTION(DRIVER_DESC);
>  MODULE_AUTHOR("Javier Martinez Canillas <javierm@...hat.com>");
>  MODULE_LICENSE("GPL v2");
> +MODULE_IMPORT_NS(DRM_SSD130X);

-- 
With Best Regards,
Andy Shevchenko