[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220413172813.GB547134@p14s>
Date: Wed, 13 Apr 2022 11:28:13 -0600
From: Mathieu Poirier <mathieu.poirier@...aro.org>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: bjorn.andersson@...aro.org, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
linux-imx@....com, linux-remoteproc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
shengjiu.wang@....com, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V2 0/2] remoteproc: elf: ignore PT_LOAD type segment with
memsz as 0
On Wed, Apr 13, 2022 at 11:30:36AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
>
> V2:
> Add R-b/A-b tag
> Drop inaccurate comment in patch 1
>
> i.MX DSP firmware has segments with PT_LOAD and memsz/filesz as zero.
> It is valid case the memsz set to zero according to elf spec:
> https://refspecs.linuxbase.org/elf/elf.pdf page 40
>
> So we could let remoteproc elf loader handle this case, then no
> duplicate code in imx dsp rproc driver
>
> Tested i.MX8MP DSP and M7 remoteproc
>
> Peng Fan (2):
> remoteproc: elf_loader: skip segment with memsz as zero
> remoteproc: imx_dsp_rproc: use common rproc_elf_load_segments
>
> drivers/remoteproc/imx_dsp_rproc.c | 95 +---------------------
> drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
> 2 files changed, 2 insertions(+), 95 deletions(-)
>
I have applied this set but as I pointed out in the previous revision, it will
have to be backed-out if something breaks. Hopefully it won't get to that.
Thanks,
Mathieu
> --
> 2.25.1
>
Powered by blists - more mailing lists