linux-kernel - Re: [Patch v7 2/4] memory: tegra: Add MC error logging on tegra186 onward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3af41bc-5d7e-660d-37b6-d0be80cd63b1@collabora.com>
Date:   Thu, 14 Apr 2022 00:17:41 +0300
From:   Dmitry Osipenko <dmitry.osipenko@...labora.com>
To:     Ashish Mhetre <amhetre@...dia.com>, digetx@...il.com,
        krzysztof.kozlowski@...aro.org, thierry.reding@...il.com,
        jonathanh@...dia.com, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org
Cc:     vdumpa@...dia.com, Snikam@...dia.com
Subject: Re: [Patch v7 2/4] memory: tegra: Add MC error logging on tegra186
 onward

On 4/13/22 12:40, Ashish Mhetre wrote:
> +static inline u32 mc_ch_readl(const struct tegra_mc *mc, int ch,
> +			      unsigned long offset)
> +{

return 0 if mc->bcast_ch_regs==NULL

> +	if (ch == MC_BROADCAST_CHANNEL)
> +		return readl_relaxed(mc->bcast_ch_regs + offset);
> +
> +	return readl_relaxed(mc->ch_regs[ch] + offset);
> +}
> +
> +static inline void mc_ch_writel(const struct tegra_mc *mc, int ch,
> +				u32 value, unsigned long offset)
> +{

return if mc->bcast_ch_regs==NULL

> +	if (ch == MC_BROADCAST_CHANNEL)
> +		writel_relaxed(value, mc->bcast_ch_regs + offset);
> +	else
> +		writel_relaxed(value, mc->ch_regs[ch] + offset);
> +}