linux-kernel - Re: [PATCH] mm/smaps_rollup: return empty file for kthreads instead of ESRCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220413142748.a5796e31e567a6205c850ae7@linux-foundation.org>
Date:   Wed, 13 Apr 2022 14:27:48 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     "Alex Xu (Hello71)" <alex_y_xu@...oo.ca>
Cc:     Vlastimil Babka <vbabka@...e.cz>,
        Daniel Colascione <dancol@...gle.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Alexey Dobriyan <adobriyan@...il.com>,
        linux-api@...r.kernel.org
Subject: Re: [PATCH] mm/smaps_rollup: return empty file for kthreads instead
 of ESRCH

On Wed, 13 Apr 2022 17:13:57 -0400 "Alex Xu (Hello71)" <alex_y_xu@...oo.ca> wrote:

> This restores the behavior prior to 258f669e7e88 ("mm:
> /proc/pid/smaps_rollup: convert to single value seq_file"), making it
> once again consistent with maps and smaps, and allowing patterns like
> awk '$1=="Anonymous:"{x+=$2}END{print x}' /proc/*/smaps_rollup to work.
> Searching all Debian packages for "smaps_rollup" did not find any
> programs which would be affected by this change.

Thanks.

258f669e7e88 was 4 years ago, so I guess a -stable backport isn't
really needed.

However, we need to be concerned about causing new regressions, and I
don't think you've presented enough information for this to be determined.

So please provide us with a full description of how the smaps_rollup
output will be altered by this patch.  Quoting example output would be
helpful.