linux-kernel - Re: [PATCH net-next v3] net/ipv6: Introduce accept_unsolicited_na knob to implement router-side changes for RFC9131

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <350f6a02-2975-ac1b-1c9d-ab738722a9fe@kernel.org>
Date:   Wed, 13 Apr 2022 16:07:28 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Arun Ajith S <aajith@...sta.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, yoshfuji@...ux-ipv6.org,
        kuba@...nel.org, pabeni@...hat.com, corbet@....net,
        prestwoj@...il.com, gilligan@...sta.com, noureddine@...sta.com,
        gk@...sta.com
Subject: Re: [PATCH net-next v3] net/ipv6: Introduce accept_unsolicited_na
 knob to implement router-side changes for RFC9131

On 4/13/22 8:34 AM, Arun Ajith S wrote:
> diff --git a/tools/testing/selftests/net/ndisc_unsolicited_na_test.py b/tools/testing/selftests/net/ndisc_unsolicited_na_test.py
> new file mode 100755
> index 000000000000..f508657ee126
> --- /dev/null
> +++ b/tools/testing/selftests/net/ndisc_unsolicited_na_test.py
> @@ -0,0 +1,255 @@
> +#!/bin/bash

that file name suffix should be .sh since it is a bash script; not .py

other than that looks good to me.

Reviewed-by: David Ahern <dsahern@...nel.org>