linux-kernel - Re: [PATCH v5 2/2] watchdog: Add Renesas RZ/N1 Watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e433c3b8-5118-47ad-0cfd-8ca79acbf7e0@traphandler.com>
Date:   Wed, 13 Apr 2022 09:55:39 +0200
From:   Jean-Jacques Hiblot <jjhiblot@...phandler.com>
To:     Tzung-Bi Shih <tzungbi@...nel.org>
CC:     <linux@...ck-us.net>, <wim@...ux-watchdog.org>,
        <geert+renesas@...der.be>, <linux-watchdog@...r.kernel.org>,
        <linux-renesas-soc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Phil Edworthy <phil.edworthy@...esas.com>
Subject: Re: [PATCH v5 2/2] watchdog: Add Renesas RZ/N1 Watchdog driver


On 11/04/2022 03:50, Tzung-Bi Shih wrote:
> On Fri, Apr 08, 2022 at 10:02:05PM +0200, Jean-Jacques Hiblot wrote:
>> From: Phil Edworthy <phil.edworthy@...esas.com>
>>
>> This is a driver for the standard WDT on the RZ/N1 devices. This WDT has
>> very limited timeout capabilities. However, it can reset the device.
>> To do so, the corresponding bits in the SysCtrl RSTEN register need to
>> be enabled. This is not done by this driver.
>>
>> Signed-off-by: Phil Edworthy <phil.edworthy@...esas.com>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@...phandler.com>
> With a minor comment:
> Reviewed-by: Tzung-Bi Shih <tzungbi@...nel.org>

Thanks for the time you took reviewing this.

>
>> +static int rzn1_wdt_probe(struct platform_device *pdev)
>> +{
> [...]
>> +	wdt->wdtdev.timeout = DEFAULT_TIMEOUT;
>> +	ret = watchdog_init_timeout(&wdt->wdtdev, 0, dev);
> Could it drop the assignment if `ret` is unused?

I'll keep the assignment but check the value: watchdog_timeout_invalid()

will return an error if the dt supplied value is out of range.

JJ