linux-kernel - Re: [RFC 13/13] net: ti: icssg-prueth: Add ICSSG ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5b8606c-c729-cddb-8fff-6240453a88fb@kernel.org>
Date:   Wed, 13 Apr 2022 11:09:42 +0300
From:   Roger Quadros <rogerq@...nel.org>
To:     Puranjay Mohan <p-mohan@...com>, Andrew Lunn <andrew@...n.ch>
Cc:     linux-kernel@...r.kernel.org, bjorn.andersson@...aro.org,
        mathieu.poirier@...aro.org, krzysztof.kozlowski+dt@...aro.org,
        linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
        nm@...com, ssantosh@...nel.org, s-anna@...com,
        linux-arm-kernel@...ts.infradead.org, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org, vigneshr@...com,
        kishon@...com, Grygorii Strashko <grygorii.strashko@...com>
Subject: Re: [RFC 13/13] net: ti: icssg-prueth: Add ICSSG ethernet driver



On 12/04/2022 12:46, Puranjay Mohan wrote:
> +Roger, Grygorii
> 
> On 07/04/22 00:12, Andrew Lunn wrote:
>>> +config TI_ICSSG_PRUETH
>>> +	tristate "TI Gigabit PRU Ethernet driver"
>>> +	select TI_DAVINCI_MDIO
>>> +
>>
>> I don't see a dependency on TI_DAVINCI_MDIO in the code. All you need
>> is an MDIO bus so that your phy-handle has somewhere to point. But that
>> could be a GPIO bit banger.
>>
>> What i do think is missing here is a dependency on PHYLIB.

That is correct.

>>
>> If possible, it would be good to also have it compile when
>> COMPILE_TEST is set.
>>

Yes, that is a good idea.

cheers,
-roger