lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Apr 2022 16:27:59 +0800 From: Haowen Bai <baihaowen@...zu.com> To: Geert Uytterhoeven <geert+renesas@...der.be>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org> CC: Haowen Bai <baihaowen@...zu.com>, <linux-renesas-soc@...r.kernel.org>, <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: [PATCH] clk: renesas: Fix memory leak of 'cpg' Fix this issue by freeing the cpg when exiting the function in the error/normal path. Signed-off-by: Haowen Bai <baihaowen@...zu.com> --- drivers/clk/renesas/clk-r8a73a4.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/clk/renesas/clk-r8a73a4.c b/drivers/clk/renesas/clk-r8a73a4.c index cfed11c659d9..5a8d976f49e0 100644 --- a/drivers/clk/renesas/clk-r8a73a4.c +++ b/drivers/clk/renesas/clk-r8a73a4.c @@ -215,7 +215,7 @@ static void __init r8a73a4_cpg_clocks_init(struct device_node *np) cpg->reg = of_iomap(np, 0); if (WARN_ON(cpg->reg == NULL)) - return; + goto out_free_cpg; for (i = 0; i < num_clks; ++i) { const char *name; @@ -233,6 +233,9 @@ static void __init r8a73a4_cpg_clocks_init(struct device_node *np) } of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data); +out_free_cpg: + kfree(cpg); + kfree(clks); } CLK_OF_DECLARE(r8a73a4_cpg_clks, "renesas,r8a73a4-cpg-clocks", r8a73a4_cpg_clocks_init); -- 2.7.4
Powered by blists - more mailing lists