[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220413084941.GB521036@leoy-ThinkPad-X240s>
Date: Wed, 13 Apr 2022 16:49:41 +0800
From: Leo Yan <leo.yan@...aro.org>
To: German Gomez <german.gomez@....com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
James Clark <james.clark@....com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf report: Set PERF_SAMPLE_DATA_SRC bit for Arm SPE
event
On Wed, Apr 13, 2022 at 09:15:40AM +0100, German Gomez wrote:
[...]
> > if (sort__mode == SORT_MODE__MEMORY) {
> > + /*
> > + * FIXUP: prior to kernel 5.18, Arm SPE missed to set
> > + * PERF_SAMPLE_DATA_SRC bit in sample type. For backward
> > + * compatibility, set the bit if it's an old perf data file.
> > + */
> > + evlist__for_each_entry(session->evlist, evsel) {
> > + if (strstr(evsel->name, "arm_spe_") &&
>
> This didn't work for me when the file recorded "-e arm_spe//" instead of
> "-e arm_spe_0//". Could you remove the trailing _? With that:
Sure, will change to "arm_spe". Just curious, if there any local
change at your side so we have the different event name?
> Tested-by: German Gomez <german.gomez@....com>
Thanks a lot, German!
Leo
Powered by blists - more mailing lists