linux-kernel - Re: [PATCH] staging: r8188eu: remove else after return and break statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Apr 2022 11:02:58 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Pavel Skripkin <paskripkin@...il.com>
cc:     Mahak Gupta <mahak_g@...iitr.ac.in>, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, gregkh@...uxfoundation.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: r8188eu: remove else after return and break
 statements



On Wed, 13 Apr 2022, Pavel Skripkin wrote:

> Hi Mahak,
>
> On 4/13/22 08:27, Mahak Gupta wrote:
> > Else is not necessary after return and break statements, hence remove
> > it.
> >
> > Reported by checkpatch:
> >
> > WARNING: else is not generally useful after a break or return
> >
> > Signed-off-by: Mahak Gupta <mahak_g@...iitr.ac.in>
>
> [snip]
>
> > -	}
> > +	/*  could be pure B, pure G, or B/G */
> > +	if (rtw_is_cckratesonly_included(rate))
> > +		return WIRELESS_11B;
> > +	else if (rtw_is_cckrates_included(rate))
> > +		return	WIRELESS_11BG;
> > +	else
> > +		return WIRELESS_11G;
>
> This 'else' is after 'return' as well, isn't it? Just wondering what's the
> difference between this one and others in this patch

Maybe it's nice to have the three options lined up?

julia