linux-kernel - Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Apr 2022 13:42:54 +0300
From:   Roger Quadros <rogerq@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        krzk@...nel.org
Cc:     linux-omap@...r.kernel.org, nm@...com,
        linux-kernel@...r.kernel.org, kishon@...com, tony@...mide.com,
        miquel.raynal@...tlin.com, vigneshr@...com
Subject: Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build

Hi Krzysztof,

On 13/04/2022 13:20, Krzysztof Kozlowski wrote:
> On 13/04/2022 11:50, Krzysztof Kozlowski wrote:
>> On 13/04/2022 11:43, Krzysztof Kozlowski wrote:
>>> On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote:
>>>> These patches allow OMAP_GPMC config to be visible in menuconfig
>>>> and buildable as a module.
>>>>
>>>> Changelog:
>>>> v3:
>>>> - Remove not required MODULE_ALIAS
>>>> - Mention in commit message why we need to remove of_match_node() call
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>> [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable
>>>       commit: 656d1be692be78b825954e0a2a47fcae81834633
>>> [2/2] memory: omap-gpmc: Allow building as a module
>>>       commit: eb55c7180be67774aa728a3c450de441e0dedb5d
>>
>> And dropped. You have a checkpatch issue:
>>
>> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module:
>> Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
>> #127: FILE: drivers/memory/omap-gpmc.c:2664:
>> +MODULE_LICENSE("GPL v2");
> 
> I kept your first patch (visible/selectable) but I think it should be
> dropped as well. You need to test it more:
> 
> https://krzk.eu/#/builders/63/builds/162

Thanks for the report. I will fix the issues.

cheers,
-roger