linux-kernel - Re: [PATCH v2] phy: mapphone-mdm6600: Fix PM error handling in phy_mdm6600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ylar+x3fI9DpmeKB@matsya>
Date:   Wed, 13 Apr 2022 16:24:51 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Tony Lindgren <tony@...mide.com>,
        linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] phy: mapphone-mdm6600: Fix PM error handling in
 phy_mdm6600_probe

On 01-03-22, 02:46, Miaoqian Lin wrote:
> The pm_runtime_enable will increase power disable depth.
> If the probe fails, we should use pm_runtime_disable() to balance
> pm_runtime_enable(). And use pm_runtime_dont_use_autosuspend() to
> undo pm_runtime_use_autosuspend()
> In the PM Runtime docs:
>     Drivers in ->remove() callback should undo the runtime PM changes done
>     in ->probe(). Usually this means calling pm_runtime_disable(),
>     pm_runtime_dont_use_autosuspend() etc.
> 
> We should do this in error handling.

Applied, thanks

-- 
~Vinod