linux-kernel - Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdafb49b-9349-087b-f483-4da888193683@kernel.org>
Date:   Wed, 13 Apr 2022 14:33:23 +0300
From:   Roger Quadros <rogerq@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        krzk@...nel.org
Cc:     linux-omap@...r.kernel.org, nm@...com,
        linux-kernel@...r.kernel.org, kishon@...com, tony@...mide.com,
        miquel.raynal@...tlin.com, vigneshr@...com
Subject: Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build

On 13/04/2022 14:05, Krzysztof Kozlowski wrote:
> On 13/04/2022 13:01, Roger Quadros wrote:
>>> https://krzk.eu/#/builders/63/builds/162
>>>
>>>
>>>>  config OMAP_GPMC
>>>> -	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
>>>> -	depends on OF_ADDRESS
>>>> +	bool "Texas Instruments OMAP SoC GPMC driver"
>>>> +	depends on OF_ADDRESS || COMPILE_TEST
>>
>>
>> Looks like include/linux/irqdomain.h does not have fallbacks if
>> CONFIG_IRQ_DOMAIN is not enabled.
>>
>> I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN.
>> Is that OK?
> 
> Previously it was building with COMPILE_TEST on sparc, so what else changed?
> 
Previously it was like so

	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
	depends on OF_ADDRESS

Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set.

And OF_ADDRESS is not set for sparc

config OF_ADDRESS
        def_bool y
        depends on !SPARC && (HAS_IOMEM || UML)

cheers,
-roger