linux-kernel - Re: [PATCH] firmware: qcom_scm: Add compatible for ipq806x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 21:38:36 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom_scm: Add compatible for ipq806x

On Thu 10 Mar 16:07 CST 2022, Ansuel Smith wrote:

> Add compatible for ipq806x. Just like ipq4019, ipq806x doesn't require
> Core, Iface or Bus clock.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> ---
>  drivers/firmware/qcom_scm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 7db8066b19fd..7348c5894821 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1338,6 +1338,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
>  							     SCM_HAS_IFACE_CLK |
>  							     SCM_HAS_BUS_CLK)
>  	},
> +	{ .compatible = "qcom,scm-ipq806x" },

If you in your dt do:

	compatible = "qcom,scm-ipq806x", "qcom,scm";

Then we don't need to update the driver for each platform, only the DT
binding.

And if we some day need to quirk something off qcom,scm-ipq806x we have
that option.

Thanks,
Bjorn

>  	{ .compatible = "qcom,scm-ipq4019" },
>  	{ .compatible = "qcom,scm-mdm9607", .data = (void *)(SCM_HAS_CORE_CLK |
>  							     SCM_HAS_IFACE_CLK |
> -- 
> 2.34.1
>