linux-kernel - Re: [RESEND PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d2a0b92d-88a0-ebde-df1a-d2b059ec129d@linaro.org>
Date:   Wed, 13 Apr 2022 13:19:05 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Vincent Shih <vincent.sunplus@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [RESEND PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as
 maybe unused



On 13/04/2022 12:38, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@...nel.org>
> 
> "bcm_otpc_acpi_ids" is used with ACPI_PTR, so a build with !CONFIG_ACPI
> has a warning:
> 
>    drivers/nvmem/bcm-ocotp.c:247:36: error:
>      ‘bcm_otpc_acpi_ids’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Applied all thanks,

--srini
> ---
>   drivers/nvmem/bcm-ocotp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/bcm-ocotp.c b/drivers/nvmem/bcm-ocotp.c
> index a8097511582a..dfea96c52463 100644
> --- a/drivers/nvmem/bcm-ocotp.c
> +++ b/drivers/nvmem/bcm-ocotp.c
> @@ -244,7 +244,7 @@ static const struct of_device_id bcm_otpc_dt_ids[] = {
>   };
>   MODULE_DEVICE_TABLE(of, bcm_otpc_dt_ids);
>   
> -static const struct acpi_device_id bcm_otpc_acpi_ids[] = {
> +static const struct acpi_device_id bcm_otpc_acpi_ids[] __maybe_unused = {
>   	{ .id = "BRCM0700", .driver_data = (kernel_ulong_t)&otp_map },
>   	{ .id = "BRCM0701", .driver_data = (kernel_ulong_t)&otp_map_v2 },
>   	{ /* sentinel */ }