linux-kernel - Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06852353-9ca1-6f61-7447-b5f1d64ead25@linaro.org>
Date:   Wed, 13 Apr 2022 14:31:44 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Roger Quadros <rogerq@...nel.org>
Cc:     linux-omap@...r.kernel.org, nm@...com,
        linux-kernel@...r.kernel.org, kishon@...com, tony@...mide.com,
        miquel.raynal@...tlin.com, vigneshr@...com
Subject: Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build

On 13/04/2022 13:56, Roger Quadros wrote:
> 
> 
> On 13/04/2022 14:47, Krzysztof Kozlowski wrote:
>> On 13/04/2022 13:33, Roger Quadros wrote:
>>>> Previously it was building with COMPILE_TEST on sparc, so what else changed?
>>>>
>>> Previously it was like so
>>>
>>> 	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
>>> 	depends on OF_ADDRESS
>>>
>>> Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set.
>>>
>>> And OF_ADDRESS is not set for sparc
>>>
>>
>> Ah, yes, so dropping COMPILE_TEST seems the solution. There are no other
>> "depends" here.
> 
> But the build failed at irq_domain_remove() which is only available if IRQ_DOMAIN
> is enabled.
> 
> It could be possible that OF_ADDRESS is enabled but IRQ_DOMAIN is not right?

I must admit I did not dig this that much. OF_ADDRESS has !SPARC
dependency, so after removing COMPILE_TEST the issue should not happen
on SPARC. What about other platforms? They should behave I think the
same as before - fail if they were failing. Nothing gets worse which is
my main concern here.

If you have spare time, maybe you could investigate the compile testing
on other platforms as well and if something fails, fix it. But it seems
it is separate problem.

Best regards,
Krzysztof