linux-kernel - Re: [PATCH v3 0/2] PM: refactor pm_pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jDEau14RF4-pEc0HiWG+Cg7f93oMmhBXZULCXpOJFVaw@mail.gmail.com>
Date:   Wed, 13 Apr 2022 16:35:50 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     David Cohen <dacohen@...me>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/2] PM: refactor pm_pr_dbg() to support dynamic debug

On Thu, Mar 24, 2022 at 9:07 AM David Cohen <dacohen@...me> wrote:
>
> Hi,
>
> I am currently debugging an issue with s2idle on my laptop where in a
> rare occasion instead of sleeping, it gets stuck in an infinite loop.
> The pm_pr_dbg() is placed on very useful functions and it helps me to
> debug it, but the current all or nothing enabling mechanism with
> pm_debug_messages_on flag is causing the suspending mechanism to be
> disturbed with so many debug messages to the point it becomes extremely
> difficult to reproduce the issue I'm debugging. More granularity when
> enabling pm_pr_dbg() in this case is very welcome.
>
> These patches I'm sending introduce dynamic debug support to pm_pr_dbg()
> while still maintaining the pm_debug_messages_on flag behavior if
> dynamic debug is not used.
>
> Regards, David
>
> ---
> David Cohen (2):
>   PM: narrow down -DDEBUG on kernel/power/ files
>   PM: enable dynamic debug support within pm_pr_dbg()

Both patches applied as 5.19 material, thanks!