[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VexJBnAqoQ53=_nif=bso0-cNj4EsTbUwKGKxfNq_Fvyw@mail.gmail.com>
Date: Wed, 13 Apr 2022 17:51:57 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
linux-iio <linux-iio@...r.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
Cosmin Tanislav <cosmin.tanislav@...log.com>
Subject: Re: [PATCH v1 2/3] iio: ABI: adc: ad4130: document filter_mode{,_available}
On Wed, Apr 13, 2022 at 4:17 PM Cosmin Tanislav <demonsingur@...il.com> wrote:
It's good you provided documentation, but I think the part "ABI:" is
not needed in the Subject.
> AD4130-8 is an ultra-low power, high precision,
> measurement solution for low bandwidth battery
> operated applications.
>
> The fully integrated AFE (Analog Front-End)
> includes a multiplexer for up to 16 single-ended
> or 8 differential inputs, PGA (Programmable Gain
> Amplifier), 24-bit Sigma-Delta ADC, on-chip
> reference and oscillator, selectable filter
> options, smart sequencer, sensor biasing and
> excitation options, diagnostics, and a FIFO
> buffer.
Indentation issue as per patch 1.
...
> + Set the filter mode of the differential channel. When the filter
> + mode changes, the in_voltageY-voltageZ_sampling_frequency and
> + in_voltageY-voltageZ_sampling_frequency_available attributes
> + might also change to accomodate the new filter mode.
accommodate
> + If the current sampling frequency is out of range for the new
> + filter mode, the sampling frequency will be changed to the
> + closest valid one.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists