linux-kernel - Re: [PATCH 1/2] dt-bindings: rtc: Add TI K3 RTC devicetree bindings documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Apr 2022 10:45:09 -0500
From:   Nishanth Menon <nm@...com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-rtc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH 1/2] dt-bindings: rtc: Add TI K3 RTC devicetree bindings
 documentation

On 08:42-20220413, Krzysztof Kozlowski wrote:
> On 13/04/2022 00:17, Nishanth Menon wrote:
> >>> +  assigned-clocks:
> >>> +    description: |
> >>> +      override default osc32k parent clock reference to the osc32k clock entry
> >>> +    maxItems: 1
> >>> +
> >>> +  assigned-clock-parents:
> >>> +    description: |
> >>> +      override default osc32k parent clock phandle of the new parent clock of osc32k
> >>> +    maxItems: 1
> >>
> >> Usually assigned-clockXXX are not needed in the bindings. Is here
> >> something different? They are put only to indicate something special.
> > 
> > I wonder if I should rather use unevaluatedproperties instead? If I use
> > additionalProperties: False, then the second example below fails.
> > 
> 
> Are you sure it fails? I just checked and it worked in my case. This
> AFAIR was working since some time (or fixed some time ago), so maybe
> update your dtschema?

Arrgh, Thanks and you are right.
Apologies, I should have cross checked again since developing late
last year (understood the min schema currently is 2022.3).

Will fix this up in the repost v2 in a short while.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D