linux-kernel - [cel:topic-rpc-with-tls-upcall 18/21] net/sunrpc/clnt.c:2194:2: warning: unannotated fall-through between switch labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 14 Apr 2022 21:22:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chuck Lever <chuck.lever@...cle.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [cel:topic-rpc-with-tls-upcall 18/21] net/sunrpc/clnt.c:2194:2:
 warning: unannotated fall-through between switch labels

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux topic-rpc-with-tls-upcall
head:   77d1002f5a5209bebd901cf895b52730199c0ba4
commit: d7546e246acd3e74b2967985f4cae4df84fdba25 [18/21] SUNRPC: Add FSM machinery to handle RPC_AUTH_TLS on reconnect
config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20220414/202204142146.JvSVSwxH-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6b7e6ea489f6dd45a9b0da9ac20871560917b9b0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/commit/?id=d7546e246acd3e74b2967985f4cae4df84fdba25
        git remote add cel git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux
        git fetch --no-tags cel topic-rpc-with-tls-upcall
        git checkout d7546e246acd3e74b2967985f4cae4df84fdba25
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/sunrpc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/sunrpc/clnt.c:2194:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           default:
           ^
   net/sunrpc/clnt.c:2194:2: note: insert 'break;' to avoid fall-through
           default:
           ^
           break; 
   1 warning generated.


vim +2194 net/sunrpc/clnt.c

  2176	
  2177	static void
  2178	call_start_tls(struct rpc_task *task)
  2179	{
  2180		struct rpc_xprt *xprt = task->tk_rqstp->rq_xprt;
  2181		struct rpc_clnt *clnt = task->tk_client;
  2182	
  2183		task->tk_action = call_transmit;
  2184		if (RPC_IS_TLSPROBE(task))
  2185			return;
  2186	
  2187		switch (clnt->cl_xprtsec_policy) {
  2188		case RPC_XPRTSEC_TLS:
  2189		case RPC_XPRTSEC_MTLS:
  2190			if (xprt->ops->tls_handshake_async) {
  2191				task->tk_action = call_tls_status;
  2192				rpc_starttls_async(task);
  2193			}
> 2194		default:
  2195			break;
  2196		}
  2197	}
  2198	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp