linux-kernel - Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ylg7Yl9GmgpOFipk@robh.at.kernel.org>
Date:   Thu, 14 Apr 2022 10:18:58 -0500
From:   Rob Herring <robh@...nel.org>
To:     qinjian[覃健] <qinjian@...lus1.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "maz@...nel.org" <maz@...nel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>
Subject: Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021
 clock driver

On Thu, Apr 14, 2022 at 07:06:12AM +0000, qinjian[覃健] wrote:
> 
> > > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> > > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> > > +
> > > +#define XTAL            27000000
> > 
> > This looks like frequency which usually does not belong to bindings. Why
> > do you need it here?
> > 
> 
> OK, I'll remove it.

If that's the input frequency to the clock controller and it could 
possibly change, then it should be defined in DT with a 'fixed-clock' 
node and 'clocks' property in the clock controller.

Rob