lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Apr 2022 17:47:23 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Randy Dunlap <rdunlap@...radead.org> Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org, kernel test robot <lkp@...el.com>, Arnd Bergmann <arnd@...db.de>, "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Stephen Hemminger <sthemmin@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, linux-hyperv@...r.kernel.org, Michael Kelley <mikelley@...rosoft.com>, Petr Štetiar <ynezz@...e.cz> Subject: Re: [PATCH 5.4 004/475] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build On Thu, Apr 14, 2022 at 08:32:26AM -0700, Randy Dunlap wrote: > > > On 4/14/22 06:06, Greg Kroah-Hartman wrote: > > From: Randy Dunlap <rdunlap@...radead.org> > > > > commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 upstream. > > > > The hyperv utilities use PTP clock interfaces and should depend a > > a kconfig symbol such that they will be built as a loadable module or > > builtin so that linker errors do not happen. > > > > Prevents these build errors: > > > > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': > > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' > > ld: drivers/hv/hv_util.o: in function `hv_timesync_init': > > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' > > > > Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source") > > Signed-off-by: Randy Dunlap <rdunlap@...radead.org> > > Reported-by: kernel test robot <lkp@...el.com> > > Cc: Arnd Bergmann <arnd@...db.de> > > Cc: "K. Y. Srinivasan" <kys@...rosoft.com> > > Cc: Haiyang Zhang <haiyangz@...rosoft.com> > > Cc: Stephen Hemminger <sthemmin@...rosoft.com> > > Cc: Wei Liu <wei.liu@...nel.org> > > Cc: Dexuan Cui <decui@...rosoft.com> > > Cc: linux-hyperv@...r.kernel.org > > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > > Reviewed-by: Michael Kelley <mikelley@...rosoft.com> > > Link: https://lore.kernel.org/r/20211126023316.25184-1-rdunlap@infradead.org > > Signed-off-by: Wei Liu <wei.liu@...nel.org> > > Cc: Petr Štetiar <ynezz@...e.cz> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > > --- > > drivers/hv/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > --- a/drivers/hv/Kconfig > > +++ b/drivers/hv/Kconfig > > @@ -17,6 +17,7 @@ config HYPERV_TIMER > > config HYPERV_UTILS > > tristate "Microsoft Hyper-V Utilities driver" > > depends on HYPERV && CONNECTOR && NLS > > + depends on PTP_1588_CLOCK_OPTIONAL > > AFAICT PTP_1588_CLOCK_OPTIONAL does not exist in 5.4 kernels, > so this should not be used there. Gotta love it when people lie in Fixes: tags :( I'll go drop this, thanks! greg k-h
Powered by blists - more mailing lists