linux-kernel - Re: [PATCH v2 0/8] staging: r8188eu: fix and clean up some firmware code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ecf7d12-0ad9-5055-75c3-adf6e97c67cf@lwfinger.net>
Date:   Thu, 14 Apr 2022 10:48:32 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Michael Straube <straube.linux@...il.com>,
        gregkh@...uxfoundation.org
Cc:     phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/8] staging: r8188eu: fix and clean up some firmware
 code

On 4/14/22 05:43, Michael Straube wrote:
> This series fixes wrong size of struct rt_firmware_hdr in the first
> patch and does some cleanups in rtl8188e_firmware_download() in the
> other patches.
> 
> Tested on x86_64 with Inter-Tech DMG-02.
> 
> v2:
> Added a patch to check size of struct rt_firmware_hdr at compile time.

Please wait a while before submitting new versions until those of us in time 
zones further west get a chance. My objections to the logging change still apply.

NACK

Larry