linux-kernel - Re: [PATCH 09/18] objtool: Add stack validation cmdline option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220414155231.2kkpwl5oq2saef5t@treble>
Date:   Thu, 14 Apr 2022 08:52:31 -0700
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Miroslav Benes <mbenes@...e.cz>
Subject: Re: [PATCH 09/18] objtool: Add stack validation cmdline option

On Thu, Apr 14, 2022 at 10:43:25AM +0200, Peter Zijlstra wrote:
> On Wed, Apr 13, 2022 at 04:19:44PM -0700, Josh Poimboeuf wrote:
> > +	if (opts.stackval || opts.orc || opts.uaccess) {
> > +		ret = validate_functions(file);
> > +		if (ret < 0)
> > +			goto out;
> > +		warnings += ret;
> >  
> > +		ret = validate_unwind_hints(file, NULL);
> >  		if (ret < 0)
> >  			goto out;
> >  		warnings += ret;
> > +
> > +		if (!warnings) {
> > +			ret = validate_reachable_instructions(file);
> > +			if (ret < 0)
> > +				goto out;
> > +			warnings += ret;
> > +		}
> >  	}
> 
> Doesn't SLS also depend on validate_functions() ?

Doh, I had the intention of splitting that out from validate_branch()
like I did for ibt.

-- 
Josh