linux-kernel - Re: [PATCH v5 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YlhEYq8pGsuoA2mv@robh.at.kernel.org>
Date:   Thu, 14 Apr 2022 10:57:22 -0500
From:   Rob Herring <robh@...nel.org>
To:     "J, KEERTHY" <j-keerthy@...com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        daniel.lezcano@...aro.org, rui.zhang@...el.com, amitk@...nel.org,
        kristo@...nel.org, linux-pm@...r.kernel.org, vigneshr@...com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings
 documentation

On Wed, Apr 13, 2022 at 05:34:20PM +0530, J, KEERTHY wrote:
> 
> 
> On 4/13/2022 3:43 PM, Krzysztof Kozlowski wrote:
> > On 12/04/2022 12:14, Keerthy wrote:
> > > Add VTM bindings documentation. In the Voltage Thermal
> > > Management Module(VTM), K3 J72XX supplies a voltage
> > > reference and a temperature sensor feature that are gathered in the band
> > > gap voltage and temperature sensor (VBGAPTS) module. The band
> > > gap provides current and voltage reference for its internal
> > > circuits and other analog IP blocks. The analog-to-digital
> > > converter (ADC) produces an output value that is proportional
> > > to the silicon temperature.
> > > 
> > > Signed-off-by: Keerthy <j-keerthy@...com>
> > > ---
> > >   .../bindings/thermal/ti,j72xx-thermal.yaml    | 62 +++++++++++++++++++
> > >   1 file changed, 62 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> > > new file mode 100644
> > > index 000000000000..8483c495cb9a
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> > > @@ -0,0 +1,62 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Texas Instruments J72XX VTM (DTS) binding
> > > +
> > > +maintainers:
> > > +  - Keerthy <j-keerthy@...com>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: ti,j721e-vtm
> > > +    oneOf:
> > > +      - enum:
> > > +          - ti,j721e-vtm
> > > +          - ti,j7200-vtm
> > 
> > It seems you resent this ignoring all of Rob's comments. In changelog of
> > cover letter you wrote "Fixed all the comments on v4" but it's not true.
> > Maybe you sent us old patch?
> > 
> > Anyway, you need to follow Rob's comments.
> 
> Krzysztof,
> 
> Apologies. Some issues with my mailbox. Rob's response didn't reach me for
> some reason.

Maybe because I'm still banned by TI. Just had another bounce a few days 
ago.

Rob