linux-kernel - Re: [linux-stable-rc:queue/5.4 7091/9999] drivers/staging/comedi/drivers/comedi_isadma.c:25:17: error: implicit declaration of function 'claim_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Apr 2022 17:59:53 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Greg Ungerer <gerg@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>,
        kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [linux-stable-rc:queue/5.4 7091/9999] drivers/staging/comedi/drivers/comedi_isadma.c:25:17:
 error: implicit declaration of function 'claim_dma_lock'

On Thu, Apr 14, 2022 at 4:16 PM Greg Ungerer <gerg@...ux-m68k.org> wrote:
> On 13/4/22 18:54, Arnd Bergmann wrote:
> > On Wed, Apr 13, 2022 at 1:07 AM kernel test robot <lkp@...el.com> wrote:
 >
> > Greg (Ungerer), do you see any of these that are used on Coldfire?
> > I can rule out most of them, but there are a few that are unclear to me.
>
> I think the cs89x0 driver may have been used on at least one platform
> in the past. But nothing that is currently supported in mainline code.
> So we can safely assume none of these are required for ColdFire platforms.

Ok, so even if this driver is used on coldfire, it only uses the ISA DMA
code path for actual ISA devices, not for the platform device code on
non-PC systems.

I think we can just remove arch/m68k/coldfire/dma.c and most of
arch/m68k/include/asm/dma.h then after dropping CONFIG_ISA_DMA_API,
leaving only the bits needed for CONFIG_GENERIC_ISA_DMA on Q40
and AMIGA.

     Arnd