linux-kernel - Re: [PATCH V4 18/31] x86/sgx: Support modifying SGX page type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b24f781-7571-fcc4-1ba9-e77c3eaca3aa@intel.com>
Date:   Thu, 14 Apr 2022 09:32:15 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>, <dave.hansen@...ux.intel.com>,
        <tglx@...utronix.de>, <bp@...en8.de>, <luto@...nel.org>,
        <mingo@...hat.com>, <linux-sgx@...r.kernel.org>, <x86@...nel.org>,
        <shuah@...nel.org>, <linux-kselftest@...r.kernel.org>
CC:     <seanjc@...gle.com>, <kai.huang@...el.com>,
        <cathy.zhang@...el.com>, <cedric.xing@...el.com>,
        <haitao.huang@...el.com>, <mark.shanahan@...el.com>,
        <vijay.dhanraj@...el.com>, <hpa@...or.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V4 18/31] x86/sgx: Support modifying SGX page type

Hi Jarkko,

On 4/14/2022 4:11 AM, Jarkko Sakkinen wrote:
> On Wed, 2022-04-13 at 14:10 -0700, Reinette Chatre wrote:
>> @@ -97,6 +99,23 @@ struct sgx_enclave_restrict_permissions {
>>         __u64 count;
>>  };
>>  
>> +/**
>> + * struct sgx_enclave_modify_type - parameters for %SGX_IOC_ENCLAVE_MODIFY_TYPES
>> + * @offset:    starting page offset (page aligned relative to enclave base
>> + *             address defined in SECS)
>> + * @length:    length of memory (multiple of the page size)
>> + * @page_type: new type for pages in range described by @offset and @length
>> + * @result:    (output) SGX result code of ENCLS[EMODT] function
>> + * @count:     (output) bytes successfully changed (multiple of page size)
>> + */
>> +struct sgx_enclave_modify_type {
> 
> This should match the ioctl name i.e. "types".

Will do (and also the function names).

...

> 
> Other than that LGTM

Thank you

Reinette