linux-kernel - Re: [PATCH V4 00/31] x86/sgx and selftests/sgx: Support SGX2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Apr 2022 09:34:22 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>, <dave.hansen@...ux.intel.com>,
        <tglx@...utronix.de>, <bp@...en8.de>, <luto@...nel.org>,
        <mingo@...hat.com>, <linux-sgx@...r.kernel.org>, <x86@...nel.org>,
        <shuah@...nel.org>, <linux-kselftest@...r.kernel.org>
CC:     <seanjc@...gle.com>, <kai.huang@...el.com>,
        <cathy.zhang@...el.com>, <cedric.xing@...el.com>,
        <haitao.huang@...el.com>, <mark.shanahan@...el.com>,
        <vijay.dhanraj@...el.com>, <hpa@...or.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V4 00/31] x86/sgx and selftests/sgx: Support SGX2

Hi Jarkko,

On 4/14/2022 4:25 AM, Jarkko Sakkinen wrote:
> On Wed, 2022-04-13 at 14:10 -0700, Reinette Chatre wrote:
> IMHO, we can pull this after +1 version. I think I had only one nit
> (one character to a struct name it was), and I've been testing this
> series *extensively* with real-world code (wasm run-time that we are
> developing), so I'm confident that  it is *good enough*.

Thank you very much. I am aware of other teams successfully building
on and testing this work. I do hope that they could also provide an
ack to help increase the confidence in this work.

> 
> Reinette, for the EMODT patch, as long as you fix the struct name
> you can add my reviewed-by and also tested-by to that patch before
> you send it! It's so narrow change.

Thank you. I will make the struct name change and also plan to
make the same change to the function names in that patch to ensure that
everything is consistent in that regard. 

Reinette