linux-kernel - Re: [PATCH v7 00/70] Introducing the Maple Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220413235051.3a4eb7c86d31656c7aea250c@linux-foundation.org>
Date:   Wed, 13 Apr 2022 23:50:51 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Liam Howlett <liam.howlett@...cle.com>, Yu Zhao <yuzhao@...gle.com>
Cc:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 00/70] Introducing the Maple Tree

On Mon, 4 Apr 2022 14:35:26 +0000 Liam Howlett <liam.howlett@...cle.com> wrote:

> Please add this patch set to your branch.  They are based on v5.18-rc1.

Do we get a nice [0/n] cover letter telling us all about this?

I have that all merged up and it compiles.

https://lkml.kernel.org/r/20220402094550.129-1-lipeifeng@oppo.com and
https://lkml.kernel.org/r/20220412081014.399-1-lipeifeng@oppo.com are
disabled for now.

Several patches were marked

From: Liam
Signed-off-by: Matthew
Signed-off-by: Liam

Which makes me wonder whether the attribution was correct.  Please
double-check.

I made a lame attempt to fix up mglru's get_next_vma(), and it probably
wants a revisit in the maple-tree world anyway.  Please check this and
send me a better version ;)

--- a/mm/vmscan.c~mglru-vs-maple-tree
+++ a/mm/vmscan.c
@@ -3704,7 +3704,7 @@ static bool get_next_vma(struct mm_walk

 	while (walk->vma) {
 		if (next >= walk->vma->vm_end) {
-			walk->vma = walk->vma->vm_next;
+			walk->vma = find_vma(walk->mm, walk->vma->vm_end);
 			continue;
 		}

@@ -3712,7 +3712,7 @@ static bool get_next_vma(struct mm_walk
 			return false;

 		if (should_skip_vma(walk->vma->vm_start, walk->vma->vm_end, walk)) {
-			walk->vma = walk->vma->vm_next;
+			walk->vma = find_vma(walk->mm, walk->vma->vm_end);
 			continue;
 		}

@@ -4062,7 +4062,7 @@ static void walk_mm(struct lruvec *lruve
 		/* the caller might be holding the lock for write */
 		if (mmap_read_trylock(mm)) {
 			unsigned long start = walk->next_addr;
-			unsigned long end = mm->highest_vm_end;
+			unsigned long end = TASK_SIZE;

 			err = walk_page_range(mm, start, end, &mm_walk_ops, walk);

I flung a tree up at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mmtemp containing
mglru and mapletree and a few other things.  Could the mglru and
mapletree people please runtime test it, send any fixes?