linux-kernel - Re: [RFC PATCH v5 092/104] KVM: TDX: Handle TDX PV HLT hypercall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YlhVMgePjZvQWang@google.com>
Date:   Thu, 14 Apr 2022 17:09:06 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Isaku Yamahata <isaku.yamahata@...il.com>,
        isaku.yamahata@...el.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jim Mattson <jmattson@...gle.com>,
        erdemaktas@...gle.com, Connor Kuehl <ckuehl@...hat.com>
Subject: Re: [RFC PATCH v5 092/104] KVM: TDX: Handle TDX PV HLT hypercall

On Mon, Apr 11, 2022, Paolo Bonzini wrote:
> On 4/8/22 16:51, Sean Christopherson wrote:
> > > It also documents how it has to be used.  So this looks more or less okay,
> > > just rename "vmxip" to "interrupt_pending_delivery".
> > 
> > If we're keeping the call back into SEAM, then this belongs in the path of
> > apic_has_interrupt_for_ppr(), not in the HLT-exit path.  To avoid multiple SEAMCALLS
> > in a single exit, VCPU_EXREG_RVI can be added.
> 
> But apic_has_interrupt_for_ppr takes a PPR argument and that is not
> available.
> 
> So I suppose you mean kvm_apic_has_interrupt?

Yeah, I realized that when I actually tried to implement my idea in code :-)

My hopefully-fully-thought-out idea for handling this:

https://lore.kernel.org/all/YlBhuWElVRwYrrS+@google.com
https://lore.kernel.org/all/YlBkiOmTGk8VlWFh@google.com