linux-kernel - Re: [PATCH 03/14] perf vendor events intel: Add sapphirerapids events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28285c3a-a577-14ca-5e88-6101217ea73f@linux.intel.com>
Date:   Thu, 14 Apr 2022 14:25:01 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Ian Rogers <irogers@...gle.com>,
        Xing Zhengjun <zhengjun.xing@...ux.intel.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Andi Kleen <ak@...ux.intel.com>,
        John Garry <john.garry@...wei.com>,
        James Clark <james.clark@....com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 03/14] perf vendor events intel: Add sapphirerapids events



On 4/14/2022 12:36 PM, Ian Rogers wrote:
> On Thu, Apr 14, 2022 at 8:03 AM Liang, Kan <kan.liang@...ux.intel.com> wrote:
>>
>>
>>
>> On 4/13/2022 5:04 PM, Ian Rogers wrote:
>>> Events were generated from 01.org using:
>>> https://github.com/intel/event-converter-for-linux-perf
>>>
>>> Signed-off-by: Ian Rogers<irogers@...gle.com>
>>> ---
>>>    tools/perf/pmu-events/arch/x86/mapfile.csv    |    1 +
>>>    .../arch/x86/sapphirerapids/cache.json        | 1083 ++++++++++++++
>>>    .../x86/sapphirerapids/floating-point.json    |  218 +++
>>>    .../arch/x86/sapphirerapids/frontend.json     |  471 ++++++
>>>    .../arch/x86/sapphirerapids/memory.json       |  415 ++++++
>>>    .../arch/x86/sapphirerapids/other.json        |  329 +++++
>>>    .../arch/x86/sapphirerapids/pipeline.json     | 1271 +++++++++++++++++
>>>    .../x86/sapphirerapids/virtual-memory.json    |  225 +++
>>
>> Thank you very much Ian for the patches. They all looks good to me.
>>
>>       Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>
>>
>> BTW: I think the uncore events for SPR are also published in 01.org.
>> Do you have plan to add them later?
> 
> Thanks Kan, we need to add the csv file to the github project to make
> this work. I can make a basic one if that works?
> 

I think Zhengjun may already have one. Zhengjun?

Thanks,
Kan