linux-kernel - Re: [PATCH V2 1/3] dt-bindings: clk: sprd: Add bindings for ums512 clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Apr 2022 13:59:45 -0500
From:   Rob Herring <robh@...nel.org>
To:     Cixi Geng <gengcixi@...il.com>
Cc:     linux-clk@...r.kernel.org, mturquette@...libre.com,
        robh+dt@...nel.org, devicetree@...r.kernel.org, sboyd@...nel.org,
        baolin.wang7@...il.com, zhang.lyra@...il.com,
        linux-kernel@...r.kernel.org, orsonzhai@...il.com
Subject: Re: [PATCH V2 1/3] dt-bindings: clk: sprd: Add bindings for ums512 clock controller

On Thu, 14 Apr 2022 20:26:55 +0800, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@...soc.com>
> 
> Add a new bindings to describe ums512 clock compatible string.
> 
> Signed-off-by: Cixi Geng <cixi.geng1@...soc.com>
> ---
>  .../bindings/clock/sprd,ums512-clk.yaml       | 108 ++++++++++++++++++
>  1 file changed, 108 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml:22:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml: properties:clock-names: {'minItems': 1, 'maxItems': 4, 'items': [{'const': 'ext-26m'}, {'const': 'ext-32k'}, {'const': 'ext-4m'}, {'const': 'rco-100m'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml: ignoring, error in schema: properties: clock-names
Documentation/devicetree/bindings/clock/sprd,ums512-clk.example.dtb:0:0: /example-0/soc/clock-controller@...00000: failed to match any schema with compatible: ['sprd,ums512-ap-clk']
Documentation/devicetree/bindings/clock/sprd,ums512-clk.example.dtb:0:0: /example-0/soc/syscon@...00000: failed to match any schema with compatible: ['sprd,ums512-glbregs', 'syscon', 'simple-mfd']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.