linux-kernel - Re: [PATCH v2 1/2] dt-bindings: i2c: add property to avoid device detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ylh4sexTQhAjU3NW@robh.at.kernel.org>
Date:   Thu, 14 Apr 2022 14:40:33 -0500
From:   Rob Herring <robh@...nel.org>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
Cc:     "wsa@...nel.org" <wsa@...nel.org>, kernel <kernel@...s.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: add property to avoid device
 detection

On Thu, Apr 14, 2022 at 10:55:40AM +0200, Vincent Whitchurch wrote:
> On Tue, Apr 12, 2022 at 11:22:41PM +0200, Rob Herring wrote:
> > On Tue, Apr 12, 2022 at 10:50:45AM +0200, Vincent Whitchurch wrote:
> > > diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt
> > > index fc3dd7ec0445..960d1d5c9362 100644
> > > --- a/Documentation/devicetree/bindings/i2c/i2c.txt
> > > +++ b/Documentation/devicetree/bindings/i2c/i2c.txt
> > > @@ -72,6 +72,10 @@ wants to support one of the below features, it should adapt these bindings.
> > >  	this information to adapt power management to keep the arbitration awake
> > >  	all the time, for example. Can not be combined with 'single-master'.
> > >  
> > > +- no-detect
> > > +	states that no other devices are present on this bus other than the
> > > +	ones listed in the devicetree.
> > 
> > This belongs in the schema instead:
> > 
> > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml
> 
> OK, thank you, I've sent a PR[0] now, but I must admit I don't quite
> understand how this property differs from the other ones in this file
> which aren't documented there.

Thanks.

The issue in general is we need permission to relicense anything in the 
kernel tree to move it. In some cases, the schema is written, but the
descriptions have not been moved (as that's the part needing to be 
copied. If we missed properties, I'm not sure what happened but they 
should be in the schema too. Maybe they were added around the same time 
the schema got written.

Rob