linux-kernel - Re: [PATCH 4/4] selftest/vm: add skip support to mremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae52647e-8d14-b86b-eea3-24331ad488b0@linuxfoundation.org>
Date:   Thu, 14 Apr 2022 15:49:49 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Sidhartha Kumar <sidhartha.kumar@...cle.com>, shuah@...nel.org,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 4/4] selftest/vm: add skip support to mremap_test

On 4/14/22 11:15 AM, Sidhartha Kumar wrote:
> Allow the mremap test to be skipped due to errors
> such as failing to find a valid remap region and
> failure to parse the mmap_min_addr sysctl.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>
> ---
>   tools/testing/selftests/vm/run_vmtests.sh | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh
> index 88e15fbb5027..eae98f5de2cc 100755
> --- a/tools/testing/selftests/vm/run_vmtests.sh
> +++ b/tools/testing/selftests/vm/run_vmtests.sh
> @@ -272,11 +272,16 @@ echo "-------------------"
>   echo "running mremap_test"
>   echo "-------------------"
>   ./mremap_test
> -if [ $? -ne 0 ]; then
> +ret_val=$?
> +
> +if [ $ret_val -eq 0 ]; then
> +	echo "[PASS]"
> +elif [ $ret_val -eq $ksft_skip ]; then
> +	 echo "[SKIP]"
> +	 exitcode=$ksft_skip
> +else
>   	echo "[FAIL]"
>   	exitcode=1
> -else
> -	echo "[PASS]"
>   fi
>   
>   echo "-----------------"
> 

Thank you. Looks good to me.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah