linux-kernel - Re: [PATCH 1/1] scsi: ufs: remove redundant HPB unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44108a7ad56dd6984523af35cfa003f4ed7be41e.camel@gmail.com>
Date:   Fri, 15 Apr 2022 00:07:56 +0200
From:   Bean Huo <huobean@...il.com>
To:     Po-Wen Kao <powen.kao@...iatek.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     wsd_upstream@...iatek.com, peter.wang@...iatek.com,
        stanley.chu@...iatek.com, alice.chao@...iatek.com,
        chun-hung.wu@...iatek.com, cc.chou@...iatek.com,
        chaotian.jing@...iatek.com, jiajie.hao@...iatek.com,
        yohan.joung@...com, jason.li@...com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/1] scsi: ufs: remove redundant HPB unmap

On Thu, 2022-04-14 at 12:49 +0800, Po-Wen Kao wrote:
> Hi Bean,
> 
> The general idea looks good.
> 
> As ufshpb_issue_umap_all_req in ufshpb_state_toggle won't actually
> runs 
> at cold boot probe due to the fact that sdev are not present yet,
> this 
> should avoid sending HPB command before UAC being cleared while keeps
> HPB mapping clean when rest flow occurs.
> 
> Just a concern, shouldn't ufshpb_issue_umap_all_req be send for each 
> sdev's corresponding hpb?
> 

Hi Po Wen,

I replied in another email that setting the flag resets all active
regions in the device, which is a more efficient way, I have submitted
a fix for HPB device mode, your review and testing are welcome.

Kind regards,
Bean

> Looking forward to your further fixes.
> 
>