[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a5f3bd4c-7335-dc3c-1606-44eba9576fee@oracle.com>
Date: Thu, 14 Apr 2022 16:50:42 -0700
From: Mike Kravetz <mike.kravetz@...cle.com>
To: Peng Liu <liupeng256@...wei.com>, david@...hat.com,
akpm@...ux-foundation.org, yaozhenguo1@...il.com,
baolin.wang@...ux.alibaba.com, songmuchun@...edance.com,
liuyuntao10@...wei.com, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] hugetlb: Fix hugepages_setup when deal with
pernode
On 4/12/22 20:29, Peng Liu wrote:
> Hugepages can be specified to pernode since "hugetlbfs: extend
> the definition of hugepages parameter to support node allocation",
> but the following problem is observed.
>
> Confusing behavior is observed when both 1G and 2M hugepage is set
> after "numa=off".
> cmdline hugepage settings:
> hugepagesz=1G hugepages=0:3,1:3
> hugepagesz=2M hugepages=0:1024,1:1024
> results:
> HugeTLB registered 1.00 GiB page size, pre-allocated 0 pages
> HugeTLB registered 2.00 MiB page size, pre-allocated 1024 pages
>
> Furthermore, confusing behavior can be also observed when an
> invalid node behind a valid node. To fix this, never allocate any
> typical hugepage when an invalid parameter is received.
>
> Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation")
> Signed-off-by: Peng Liu <liupeng256@...wei.com>
> ---
> mm/hugetlb.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
Thanks!
Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>
--
Mike Kravetz
Powered by blists - more mailing lists