linux-kernel - Re: [PATCH v1 2/3] iio: ABI: adc: ad4130: document filter_mode{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Apr 2022 10:41:09 +0300
From:   Cosmin Tanislav <demonsingur@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Cosmin Tanislav <cosmin.tanislav@...log.com>
Subject: Re: [PATCH v1 2/3] iio: ABI: adc: ad4130: document
 filter_mode{,_available}



On 4/13/22 17:51, Andy Shevchenko wrote:
> On Wed, Apr 13, 2022 at 4:17 PM Cosmin Tanislav <demonsingur@...il.com> wrote:
> 
> It's good you provided documentation, but I think the part "ABI:" is
> not needed in the Subject.
> 

Then I guess I could merge this patch into the driver patch?

>> AD4130-8 is an ultra-low power, high precision,
>> measurement solution for low bandwidth battery
>> operated applications.
>>
>> The fully integrated AFE (Analog Front-End)
>> includes a multiplexer for up to 16 single-ended
>> or 8 differential inputs, PGA (Programmable Gain
>> Amplifier), 24-bit Sigma-Delta ADC, on-chip
>> reference and oscillator, selectable filter
>> options, smart sequencer, sensor biasing and
>> excitation options, diagnostics, and a FIFO
>> buffer.
> 
> Indentation issue as per patch 1.
> 
> ...
> 
>> +               Set the filter mode of the differential channel. When the filter
>> +               mode changes, the in_voltageY-voltageZ_sampling_frequency and
>> +               in_voltageY-voltageZ_sampling_frequency_available attributes
>> +               might also change to accomodate the new filter mode.
> 
> accommodate
> 
>> +               If the current sampling frequency is out of range for the new
>> +               filter mode, the sampling frequency will be changed to the
>> +               closest valid one.
> 
>