lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Apr 2022 18:16:58 -0700 From: Joe Perches <joe@...ches.com> To: Jaehee Park <jhpark1013@...il.com>, Larry.Finger@...inger.net Cc: phil@...lpotter.co.uk, gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev Subject: Re: [PATCH 4/6] staging: r8188eu: place constants on the right side of tests On Wed, 2022-04-13 at 16:11 -0400, Jaehee Park wrote: > To comply with the linux coding style, place constants on the right > side of the test in comparisons. Issue found with checkpatch. > WARNING: Comparisons should place the constant on the right side of > the test. [] > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c [] > @@ -1997,19 +1998,19 @@ void _rtw_roaming(struct adapter *padapter, struct wlan_network *tgt_network) > else > pnetwork = &pmlmepriv->cur_network; > > - if (0 < rtw_to_roaming(padapter)) { > + if (rtw_to_roaming(padapter) > 0) { Do you think this change is the same test? What happens if rtw_to_roaming returns 0? [] > - if (0 < pmlmepriv->to_roaming) { > + if (pmlmepriv->to_roaming > 0) { here too > continue; > } else { > rtw_indicate_disconnect(padapter);
Powered by blists - more mailing lists