linux-kernel - Re: [PATCH V2] clk: renesas: Fix memory leak of 'cpg'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Apr 2022 11:32:55 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Sergey Shtylyov <s.shtylyov@....ru>
Cc:     Haowen Bai <baihaowen@...zu.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] clk: renesas: Fix memory leak of 'cpg'

Hi Sergei,

On Thu, Apr 14, 2022 at 11:29 AM Sergey Shtylyov <s.shtylyov@....ru> wrote:
> On 4/13/22 11:19 AM, Haowen Bai wrote:
> > Fix this issue by freeing the cpg when exiting the function in the
> > error/normal path.
> >
> > Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> > ---
> > V1->V2: free both cpg&clks.
> >
> >  drivers/clk/renesas/clk-r8a73a4.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
>
>    2 patches with the same name won't do -- you always need to include the chip name
> part of the file name in the subject (in this case r8a73a4).

Oh, they were for multiple drivers?
I hadn't even noticed , as Gmail collapsed them all into the same thread...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds