linux-kernel - RE: staging: r8188eu: struct rt_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74ff67ec85e14e16bb2e9f57a4fccb17@AcuMS.aculab.com>
Date:   Thu, 14 Apr 2022 10:14:26 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Michael Straube' <straube.linux@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>
CC:     Phillip Potter <phil@...lpotter.co.uk>,
        Greg KH <gregkh@...uxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: staging: r8188eu: struct rt_firmware_header issues

From: Michael Straube
> Sent: 14 April 2022 11:08
> 
> On 4/14/22 10:41, David Laight wrote:
> > From: Michael Straube
> >> Sent: 13 April 2022 20:42
> >>
> >> On 4/13/22 18:27, Michael Straube wrote:
> >>> Hi all,
> >>>
> >>> I think the rt_firmware_hdr structure in rtw_fw.c has some issues.
> >>>
> >>>
> >>> struct rt_firmware_hdr {
> >>>       /*  8-byte alinment required */
> >
> > Probably need an __aligned(8) at the bottom then?
> 
> I don't see any reason why this is needed. Do I miss something?

Dunno, the comment might be wrong.

	david

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)