linux-kernel - Re: [PATCH] dt-bindings: dmaengine: qcom: gpi: Add minItems for interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ylf2gsJ+Ks0wz6i3@matsya>
Date:   Thu, 14 Apr 2022 15:55:06 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: dmaengine: qcom: gpi: Add minItems for
 interrupts

On 14-04-22, 09:36, Krzysztof Kozlowski wrote:
> On 14/04/2022 08:42, Vinod Koul wrote:
> > Add the minItems for interrupts property as well. In the absence of
> > this, we get warning if interrupts are less than 13
> > 
> > arch/arm64/boot/dts/qcom/qrb5165-rb5.dtb:
> > dma-controller@...000: interrupts: [[0, 588, 4], [0, 589, 4], [0, 590,
> > 4], [0, 591, 4], [0, 592, 4], [0, 593, 4], [0, 594, 4], [0, 595, 4], [0,
> >   596, 4], [0, 597, 4]] is too short
> > 
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > ---
> >  Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> > index 8a790ffbdaac..7d2fc4eb5530 100644
> > --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> > +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> > @@ -32,6 +32,7 @@ properties:
> >    interrupts:
> >      description:
> >        Interrupt lines for each GPI instance
> > +    minItems: 1
> 
> This should be some real case minimum, not just 1. Unless really only
> one interrupt is also possible in existing variations?

So that depends on the channels available to use which can be worst case
of 1. Maximum is 13.. Most of the controllers are between 12-13, but we
dont want to change binding in future if controller has lesser channels
right?

-- 
~Vinod