linux-kernel - Re: [PATCH V4 21/31] Documentation/x86: Introduce enclave runtime management section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0e3765e0b82beb9b4f1ae1d7ef879abd923e063.camel@kernel.org>
Date:   Thu, 14 Apr 2022 14:21:19 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Reinette Chatre <reinette.chatre@...el.com>,
        dave.hansen@...ux.intel.com, tglx@...utronix.de, bp@...en8.de,
        luto@...nel.org, mingo@...hat.com, linux-sgx@...r.kernel.org,
        x86@...nel.org, shuah@...nel.org, linux-kselftest@...r.kernel.org
Cc:     seanjc@...gle.com, kai.huang@...el.com, cathy.zhang@...el.com,
        cedric.xing@...el.com, haitao.huang@...el.com,
        mark.shanahan@...el.com, vijay.dhanraj@...el.com, hpa@...or.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 21/31] Documentation/x86: Introduce enclave runtime
 management section

On Wed, 2022-04-13 at 14:10 -0700, Reinette Chatre wrote:
> Enclave runtime management is introduced following the pattern
> of the section describing enclave building. Provide a brief
> summary of enclave runtime management, pointing to the functions
> implementing the ioctl()s that will contain details within their
> kernel-doc.
> 
> Signed-off-by: Reinette Chatre <reinette.chatre@...el.com>
> ---
> No changes since V3.
> 
> Changes since V2:
> - Remove references to ioctl() to relax permissions and update to reflect
>   function renaming sgx_ioc_enclave_restrict_perm() ->
>   sgx_ioc_enclave_restrict_permissions().
> - Rename sgx_ioc_enclave_modt -> sgx_ioc_enclave_modify_type
> 
> Changes since V1:
> - New patch.
> 
>  Documentation/x86/sgx.rst | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/x86/sgx.rst b/Documentation/x86/sgx.rst
> index 265568a9292c..10287c558485 100644
> --- a/Documentation/x86/sgx.rst
> +++ b/Documentation/x86/sgx.rst
> @@ -100,6 +100,21 @@ pages and establish enclave page permissions.
>                 sgx_ioc_enclave_init
>                 sgx_ioc_enclave_provision
>  
> +Enclave runtime management
> +--------------------------
> +
> +Systems supporting SGX2 additionally support changes to initialized
> +enclaves: modifying enclave page permissions and type, and dynamically
> +adding and removing of enclave pages. When an enclave accesses an address
> +within its address range that does not have a backing page then a new
> +regular page will be dynamically added to the enclave. The enclave is
> +still required to run EACCEPT on the new page before it can be used.
> +
> +.. kernel-doc:: arch/x86/kernel/cpu/sgx/ioctl.c
> +   :functions: sgx_ioc_enclave_restrict_permissions
> +               sgx_ioc_enclave_modify_type
> +               sgx_ioc_enclave_remove_pages
> +
>  Enclave vDSO
>  ------------
>  

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko