linux-kernel - Re: [PATCH v2] habanalabs: Stop using iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf12J8FMen1-nRMnp=fjNEFJdKsGB8qnV_NLYbG9COX3BAQ@mail.gmail.com>
Date:   Thu, 14 Apr 2022 15:49:18 +0300
From:   Oded Gabbay <ogabbay@...nel.org>
To:     Robin Murphy <robin.murphy@....com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        "list@....net:IOMMU DRIVERS <iommu@...ts.linux-foundation.org>, Joerg
        Roedel <joro@...tes.org>," <iommu@...ts.linux-foundation.org>
Subject: Re: [PATCH v2] habanalabs: Stop using iommu_present()

On Mon, Apr 11, 2022 at 3:36 PM Robin Murphy <robin.murphy@....com> wrote:
>
> Even if an IOMMU might be present for some PCI segment in the system,
> that doesn't necessarily mean it provides translation for the device
> we care about. Replace iommu_present() with a more appropriate check.
>
> Signed-off-by: Robin Murphy <robin.murphy@....com>
> ---
>
> v2: Rebase on habanalabs-next
>
>  drivers/misc/habanalabs/common/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/common/debugfs.c b/drivers/misc/habanalabs/common/debugfs.c
> index 7c4a4d504e4c..a94f01713efd 100644
> --- a/drivers/misc/habanalabs/common/debugfs.c
> +++ b/drivers/misc/habanalabs/common/debugfs.c
> @@ -722,7 +722,7 @@ static int hl_access_mem(struct hl_device *hdev, u64 addr, u64 *val,
>         if (found)
>                 return 0;
>
> -       if (!user_address || iommu_present(&pci_bus_type)) {
> +       if (!user_address || device_iommu_mapped(&hdev->pdev->dev)) {
>                 rc = -EINVAL;
>                 goto err;
>         }
> --
> 2.28.0.dirty
>
Reviewed-by: Oded Gabbay <ogabbay@...nel.org>
Applied to -next.
Thanks,
Oded