| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Apr 2022 21:11:34 +0800
From: kernel test robot <lkp@...el.com>
To: Jens Axboe <axboe@...nel.dk>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org
Subject: [axboe-block:sock-nolock.2 5/5] net/xfrm/espintcp.c:514:19: error:
too few arguments to function call, expected 2, have 1
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git sock-nolock.2
head: 95f2e3bd27b30244f79deacbc1aac49d294bd854
commit: 95f2e3bd27b30244f79deacbc1aac49d294bd854 [5/5] net: allow sk_prot->release_cb() without sock lock held
config: s390-randconfig-r044-20220414 (https://download.01.org/0day-ci/archive/20220414/202204142116.e1SadX9n-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6b7e6ea489f6dd45a9b0da9ac20871560917b9b0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?id=95f2e3bd27b30244f79deacbc1aac49d294bd854
git remote add axboe-block https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
git fetch --no-tags axboe-block sock-nolock.2
git checkout 95f2e3bd27b30244f79deacbc1aac49d294bd854
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash net/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
In file included from net/xfrm/espintcp.c:2:
In file included from include/net/tcp.h:20:
In file included from include/linux/tcp.h:17:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:464:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16'
#define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
^
In file included from net/xfrm/espintcp.c:2:
In file included from include/net/tcp.h:20:
In file included from include/linux/tcp.h:17:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
^
include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32'
#define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
^
In file included from net/xfrm/espintcp.c:2:
In file included from include/net/tcp.h:20:
In file included from include/linux/tcp.h:17:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:501:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:511:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:521:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:609:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
readsb(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:617:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
readsw(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:625:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
readsl(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:634:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
writesb(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:643:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
writesw(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:652:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
writesl(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
>> net/xfrm/espintcp.c:514:19: error: too few arguments to function call, expected 2, have 1
tcp_release_cb(sk);
~~~~~~~~~~~~~~ ^
include/net/tcp.h:337:6: note: 'tcp_release_cb' declared here
void tcp_release_cb(struct sock *sk, bool locked);
^
>> net/xfrm/espintcp.c:566:28: error: incompatible function pointer types assigning to 'void (*)(struct sock *, bool)' (aka 'void (*)(struct sock *, _Bool)') from 'void (struct sock *)' [-Werror,-Wincompatible-function-pointer-types]
espintcp_prot->release_cb = espintcp_release;
^ ~~~~~~~~~~~~~~~~
12 warnings and 2 errors generated.
vim +514 net/xfrm/espintcp.c
e27cca96cd68fa Sabrina Dubroca 2019-11-25 501
e27cca96cd68fa Sabrina Dubroca 2019-11-25 502 static void espintcp_release(struct sock *sk)
e27cca96cd68fa Sabrina Dubroca 2019-11-25 503 {
e27cca96cd68fa Sabrina Dubroca 2019-11-25 504 struct espintcp_ctx *ctx = espintcp_getctx(sk);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 505 struct sk_buff_head queue;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 506 struct sk_buff *skb;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 507
e27cca96cd68fa Sabrina Dubroca 2019-11-25 508 __skb_queue_head_init(&queue);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 509 skb_queue_splice_init(&ctx->out_queue, &queue);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 510
e27cca96cd68fa Sabrina Dubroca 2019-11-25 511 while ((skb = __skb_dequeue(&queue)))
e27cca96cd68fa Sabrina Dubroca 2019-11-25 512 espintcp_push_skb(sk, skb);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 513
e27cca96cd68fa Sabrina Dubroca 2019-11-25 @514 tcp_release_cb(sk);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 515 }
e27cca96cd68fa Sabrina Dubroca 2019-11-25 516
e27cca96cd68fa Sabrina Dubroca 2019-11-25 517 static void espintcp_close(struct sock *sk, long timeout)
e27cca96cd68fa Sabrina Dubroca 2019-11-25 518 {
e27cca96cd68fa Sabrina Dubroca 2019-11-25 519 struct espintcp_ctx *ctx = espintcp_getctx(sk);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 520 struct espintcp_msg *emsg = &ctx->partial;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 521
e27cca96cd68fa Sabrina Dubroca 2019-11-25 522 strp_stop(&ctx->strp);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 523
e27cca96cd68fa Sabrina Dubroca 2019-11-25 524 sk->sk_prot = &tcp_prot;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 525 barrier();
e27cca96cd68fa Sabrina Dubroca 2019-11-25 526
e27cca96cd68fa Sabrina Dubroca 2019-11-25 527 cancel_work_sync(&ctx->work);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 528 strp_done(&ctx->strp);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 529
e27cca96cd68fa Sabrina Dubroca 2019-11-25 530 skb_queue_purge(&ctx->out_queue);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 531 skb_queue_purge(&ctx->ike_queue);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 532
e27cca96cd68fa Sabrina Dubroca 2019-11-25 533 if (emsg->len) {
e27cca96cd68fa Sabrina Dubroca 2019-11-25 534 if (emsg->skb)
e27cca96cd68fa Sabrina Dubroca 2019-11-25 535 kfree_skb(emsg->skb);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 536 else
e27cca96cd68fa Sabrina Dubroca 2019-11-25 537 sk_msg_free(sk, &emsg->skmsg);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 538 }
e27cca96cd68fa Sabrina Dubroca 2019-11-25 539
e27cca96cd68fa Sabrina Dubroca 2019-11-25 540 tcp_close(sk, timeout);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 541 }
e27cca96cd68fa Sabrina Dubroca 2019-11-25 542
e27cca96cd68fa Sabrina Dubroca 2019-11-25 543 static __poll_t espintcp_poll(struct file *file, struct socket *sock,
e27cca96cd68fa Sabrina Dubroca 2019-11-25 544 poll_table *wait)
e27cca96cd68fa Sabrina Dubroca 2019-11-25 545 {
e27cca96cd68fa Sabrina Dubroca 2019-11-25 546 __poll_t mask = datagram_poll(file, sock, wait);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 547 struct sock *sk = sock->sk;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 548 struct espintcp_ctx *ctx = espintcp_getctx(sk);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 549
e27cca96cd68fa Sabrina Dubroca 2019-11-25 550 if (!skb_queue_empty(&ctx->ike_queue))
e27cca96cd68fa Sabrina Dubroca 2019-11-25 551 mask |= EPOLLIN | EPOLLRDNORM;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 552
e27cca96cd68fa Sabrina Dubroca 2019-11-25 553 return mask;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 554 }
e27cca96cd68fa Sabrina Dubroca 2019-11-25 555
26333c37fc285e Sabrina Dubroca 2020-04-27 556 static void build_protos(struct proto *espintcp_prot,
26333c37fc285e Sabrina Dubroca 2020-04-27 557 struct proto_ops *espintcp_ops,
26333c37fc285e Sabrina Dubroca 2020-04-27 558 const struct proto *orig_prot,
26333c37fc285e Sabrina Dubroca 2020-04-27 559 const struct proto_ops *orig_ops)
26333c37fc285e Sabrina Dubroca 2020-04-27 560 {
26333c37fc285e Sabrina Dubroca 2020-04-27 561 memcpy(espintcp_prot, orig_prot, sizeof(struct proto));
26333c37fc285e Sabrina Dubroca 2020-04-27 562 memcpy(espintcp_ops, orig_ops, sizeof(struct proto_ops));
26333c37fc285e Sabrina Dubroca 2020-04-27 563 espintcp_prot->sendmsg = espintcp_sendmsg;
26333c37fc285e Sabrina Dubroca 2020-04-27 564 espintcp_prot->recvmsg = espintcp_recvmsg;
26333c37fc285e Sabrina Dubroca 2020-04-27 565 espintcp_prot->close = espintcp_close;
26333c37fc285e Sabrina Dubroca 2020-04-27 @566 espintcp_prot->release_cb = espintcp_release;
26333c37fc285e Sabrina Dubroca 2020-04-27 567 espintcp_ops->poll = espintcp_poll;
26333c37fc285e Sabrina Dubroca 2020-04-27 568 }
26333c37fc285e Sabrina Dubroca 2020-04-27 569
:::::: The code at line 514 was first introduced by commit
:::::: e27cca96cd68fa2c6814c90f9a1cfd36bb68c593 xfrm: add espintcp (RFC 8229)
:::::: TO: Sabrina Dubroca <sd@...asysnail.net>
:::::: CC: Steffen Klassert <steffen.klassert@...unet.com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists