linux-kernel - Re: [PATCH v1 2/2] i2c: dev: Force case user pointers in compat_i2cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YlnktBB0uT3kmzo0@shikoro>
Date:   Fri, 15 Apr 2022 23:33:40 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] i2c: dev: Force case user pointers in
 compat_i2cdev_ioctl()

On Mon, Apr 11, 2022 at 09:07:52PM +0300, Andy Shevchenko wrote:
> Sparse has warned us about wrong address space for user pointers:
> 
>   i2c-dev.c:561:50: warning: incorrect type in initializer (different address spaces)
>   i2c-dev.c:561:50:    expected unsigned char [usertype] *buf
>   i2c-dev.c:561:50:    got void [noderef] __user *
> 
> Force cast the pointer to (__u8 *) that is used by I²C core code.
> 
> Note, this is an additional fix to the previously addressed similar issue
> in the I2C_RDWR case in the same function.
> 
> Fixes: 3265a7e6b41b ("i2c: dev: Add __user annotation")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)