linux-kernel - Re: [PATCH -next] ftrace: Fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YlnqTjK92J2nxQR3@bombadil.infradead.org>
Date:   Fri, 15 Apr 2022 14:57:34 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     YueHaibing <yuehaibing@...wei.com>, mingo@...hat.com,
        xiaowei66@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ftrace: Fix build warning

On Thu, Apr 07, 2022 at 10:59:17AM -0400, Steven Rostedt wrote:
> On Thu, 7 Apr 2022 15:46:12 +0800
> YueHaibing <yuehaibing@...wei.com> wrote:
> 
> > If CONFIG_SYSCTL and CONFIG_DYNAMIC_FTRACE is n, build warns:
> > 
> > kernel/trace/ftrace.c:7912:13: error: ‘is_permanent_ops_registered’ defined but not used [-Werror=unused-function]
> >  static bool is_permanent_ops_registered(void)
> >              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > kernel/trace/ftrace.c:89:12: error: ‘last_ftrace_enabled’ defined but not used [-Werror=unused-variable]
> >  static int last_ftrace_enabled;
> >             ^~~~~~~~~~~~~~~~~~~
> > 
> > Move is_permanent_ops_registered() to ifdef block and mark last_ftrace_enabled as
> > __maybe_unused to fix this.
> > 
> > Fixes: 7cde53da38a3 ("ftrace: move sysctl_ftrace_enabled to ftrace.c")
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > ---
> >  kernel/trace/ftrace.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Queued onto sysctl-testing. I have one more fix I just posted for this too.

  Luis