linux-kernel - Re: [PATCH v2 4/8] firmware_loader: Add firmware-upload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yln3yCsPK9Za2jbu@bombadil.infradead.org>
Date:   Fri, 15 Apr 2022 15:55:04 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Russ Weight <russell.h.weight@...el.com>
Cc:     rafael@...nel.org, linux-kernel@...r.kernel.org, trix@...hat.com,
        lgoncalv@...hat.com, yilun.xu@...el.com, hao.wu@...el.com,
        matthew.gerlach@...el.com, basheer.ahmed.muddebihal@...el.com,
        tianfei.zhang@...el.com
Subject: Re: [PATCH v2 4/8] firmware_loader: Add firmware-upload support

On Fri, Apr 15, 2022 at 01:08:01PM -0700, Russ Weight wrote:
> +EXPORT_SYMBOL_GPL(firmware_upload_unregister);
> diff --git a/drivers/base/firmware_loader/sysfs_upload.h b/drivers/base/firmware_loader/sysfs_upload.h
> new file mode 100644
> index 000000000000..a72d0e82e107
> --- /dev/null
> +++ b/drivers/base/firmware_loader/sysfs_upload.h
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __FIRMWARE_UPLOAD_H
> +#define __FIRMWARE_UPLOAD_H
> +
> +#include <linux/device.h>
> +
> +/* Update progress codes */
> +enum fw_upload_prog {
> +	FW_UPLOAD_PROG_IDLE,
> +	FW_UPLOAD_PROG_RECEIVING,
> +	FW_UPLOAD_PROG_PREPARING,
> +	FW_UPLOAD_PROG_TRANSFERRING,
> +	FW_UPLOAD_PROG_PROGRAMMING,
> +	FW_UPLOAD_PROG_MAX
> +};

This is all looking good to me, thanks for all the work and testing!
Can you just add kdoc entries for the above as well?

Other than that:

Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>

  Luis