linux-kernel - Re: [PATCH 2/3] virtio_net: Add control VQ struct to carry vlan id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87985be4-8cb0-2292-d799-5a91fb32acda@redhat.com>
Date:   Fri, 15 Apr 2022 11:00:37 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Eli Cohen <elic@...dia.com>, mst@...hat.com
Cc:     virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, si-wei.liu@...cle.com
Subject: Re: [PATCH 2/3] virtio_net: Add control VQ struct to carry vlan id


在 2022/4/11 20:29, Eli Cohen 写道:
> Add structure to define the payload of control VQ messages carrying the
> configured vlan ID. It will be used in subsequent patches of this
> series.
>
> Signed-off-by: Eli Cohen <elic@...dia.com>
> ---
>   include/uapi/linux/virtio_net.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
> index 3f55a4215f11..b94a405fa8d2 100644
> --- a/include/uapi/linux/virtio_net.h
> +++ b/include/uapi/linux/virtio_net.h
> @@ -270,6 +270,9 @@ struct virtio_net_ctrl_mac {
>   #define VIRTIO_NET_CTRL_VLAN       2
>    #define VIRTIO_NET_CTRL_VLAN_ADD             0
>    #define VIRTIO_NET_CTRL_VLAN_DEL             1
> +struct virtio_net_ctrl_vlan {
> +	__virtio16 id;
> +};


It looks to me there's no need to bother uAPI and we can simply use 
__virtio16 in patch 3?

Thanks


>   
>   /*
>    * Control link announce acknowledgement