linux-kernel - Re: [PATCH v2] block/compat_ioctl: fix range check in BLKGETSIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4566cd49-a9c6-f928-9834-c608dfcdf565@nvidia.com>
Date:   Fri, 15 Apr 2022 05:25:46 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Khazhismel Kumykov <khazhy@...gle.com>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Jens Axboe <axboe@...nel.dk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bart Van Assche <bvanassche@....org>
Subject: Re: [PATCH v2] block/compat_ioctl: fix range check in BLKGETSIZE

On 4/14/22 15:40, Khazhismel Kumykov wrote:
> kernel ulong and compat_ulong_t may not be same width. Use type directly
> to eliminate mismatches.
> 
> This would result in truncation rather than EFBIG for 32bit mode for
> large disks.
> 
> Reviewed-by: Bart Van Assche <bvanassche@....org>
> Signed-off-by: Khazhismel Kumykov <khazhy@...gle.com>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck